----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3136/#review7275 -----------------------------------------------------------
src/mem/ruby/slicc_interface/FirstLevelController.cc (line 1107) <http://reviews.gem5.org/r/3136/#comment6182> I would suggest to fix the size while we are at it. I guess this should be a cacheline sized request? - Andreas Hansson On Sept. 24, 2015, 2:58 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3136/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2015, 2:58 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11140:d81eda994b80 > --------------------------- > ruby: first level controller: merge eviction functions > A previous patch merged ruby port and sequencer. The sequencer used to call > upon a function from ruby port on receving eviction callbacks. Instead of > calling the function eviction function ruby port, the first level controller > will now directly execute the function itself. > > > Diffs > ----- > > src/mem/ruby/slicc_interface/FirstLevelController.hh PRE-CREATION > src/mem/ruby/slicc_interface/FirstLevelController.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3136/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
