----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3145/#review7330 -----------------------------------------------------------
Ship it! I guess it should be "mem:" in the heading? Also, what constitues noise probably depends on the observer in this case. I agree that we need some further classification though... - Andreas Hansson On Oct. 4, 2015, 6:24 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3145/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2015, 6:24 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11156:311127245c41 > --------------------------- > cache: add CacheVerbose debug flag, filter noisy DPRINTFs > > Some of the DPRINTFs added to the classic cache in cset 45df88079f04, > while useful to those unfamiliar with the cache code, end up being > noise when you're familiar with the code but are trying to debug tricky > protocol issues. (Particularly getting two messages from each cache > as it receives a snoop request then declares that there was no match.) > > This patch introduces a CacheVerbose debug flag, and moves a subset of > the added printfs into that category, so that Cache by itself returns > to being a more succinct summary of cache activity. > > Also added a CacheAll compound flag to turn on all the cache-related > debug flags (other than CacheTags, which you *really* have to want badly > to turn it on, IMO). > > > Diffs > ----- > > src/mem/cache/SConscript d660f0d38e3baa1bcaf5a570c270ffa8d98e1d45 > src/mem/cache/cache.cc d660f0d38e3baa1bcaf5a570c270ffa8d98e1d45 > > Diff: http://reviews.gem5.org/r/3145/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
