> On Nov. 2, 2015, 6:03 p.m., Jason Lowe-Power wrote: > > Is this function defined in another patch? > > Tony Gutierrez wrote: > Yes, it's added here: http://reviews.gem5.org/r/3185/ . We can add this > change to that patch as well, if you'd like.
It would be good if you would either put the function definition in this patch, or just move this change to the other patch. As it is, there isn't anything to "review" here :). - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3186/#review7436 ----------------------------------------------------------- On Oct. 30, 2015, 9:52 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3186/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 9:52 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11192:34f9a235f2f4 > --------------------------- > ruby: fillMask helper function > > > Diffs > ----- > > src/mem/protocol/RubySlicc_Exports.sm > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > > Diff: http://reviews.gem5.org/r/3186/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
