----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3291/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11308:17f6da8cf97c --------------------------- x86: revamp cmpxchg8b/cmpxchg16b implementation The previous implementation did a pair of nested RMW operations, which isn't compatible with the way that locked RMW operations are implemented in the cache models. It was convenient though in that it didn't require any new micro-ops, and supported cmpxchg16b using 64-bit memory ops. It also worked in AtomicSimpleCPU where atomicity was guaranteed by the core and not by the memory system. It did not work with timing CPU models though. This new implementation defines new 'split' load and store micro-ops which allow a single memory operation to use a pair of registers as the source or destination, then uses a single ldsplit/stsplit RMW pair to implement cmpxchg. This patch requires support for 128-bit memory accesses in the ISA (added via a separate patch) to support cmpxchg16b. Diffs ----- src/arch/x86/insts/microldstop.hh d06e5a6b4b7f05a642c3e2bee12cfeb130dede16 src/arch/x86/insts/microldstop.cc d06e5a6b4b7f05a642c3e2bee12cfeb130dede16 src/arch/x86/isa/insts/general_purpose/semaphores.py d06e5a6b4b7f05a642c3e2bee12cfeb130dede16 src/arch/x86/isa/microops/ldstop.isa d06e5a6b4b7f05a642c3e2bee12cfeb130dede16 src/arch/x86/isa/operands.isa d06e5a6b4b7f05a642c3e2bee12cfeb130dede16 Diff: http://reviews.gem5.org/r/3291/diff/ Testing ------- Thanks, Steve Reinhardt _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
