----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3287/#review7931 -----------------------------------------------------------
Ship it! Looks good to me. - Curtis Dunham On Jan. 19, 2016, 3:48 a.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3287/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2016, 3:48 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11306:50e5c080c30d > --------------------------- > arch: get rid of dummy var init > > MemOperand variables were being initialized to 0 > "to avoid 'uninitialized variable' errors" but these > no longer seem to be a problem (with the exception of > one use case in POWER that is arguably broken and > easily fixed here). > > Getting rid of the initialization is necessary to > set up a subsequent patch which extends memory > operands to possibly not be scalars, making the > '= 0' initialization no longer feasible. > > > Diffs > ----- > > src/arch/power/isa/decoder.isa d06e5a6b4b7f05a642c3e2bee12cfeb130dede16 > src/arch/isa_parser.py d06e5a6b4b7f05a642c3e2bee12cfeb130dede16 > > Diff: http://reviews.gem5.org/r/3287/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
