I hadn't heard of it---looks nice. We were just discussing yesterday that the current script is pretty limited because it's not actually parsing the code.
I've spent enough time messing around with this stuff for now though---I'll let someone else pick that up if they're inspired. Steve On Fri, Jan 29, 2016 at 10:48 AM nathan binkert <[email protected]> wrote: > Have you guys played with clang-format? It's awesome and very > configurable. You could consider at least running that on the whole > codebase and then adding a prechangegroup hook on the server to reject > pushes once it's done. > > Nate > > On Thu, Jan 28, 2016 at 10:14 AM, Steve Reinhardt <[email protected]> > wrote: > > > On Thu, Jan 28, 2016 at 9:35 AM Andreas Sandberg < > [email protected] > > > > > wrote: > > > > > > > > You¹re probably right, rewrite is probably a better description. I > > suspect > > > we¹ll have to create some abstraction layer that allows us to extract > > > diffs from both Mercurial and git if we want to keep the ability to > apply > > > the style checker to a subset of a file. However, I¹m not sure if > that¹s > > > desirable. I have had issues with the style checker (false positives > and > > > negatives) due to the partial view in the past, so it might make sense > to > > > apply it to the entire files instead of individual changes. > > > > > > > Yes, doing whole files makes sense to me. We need to make a pass and > clean > > up all the existing issues before we do that though. I'm planning to do > > that anyway. > > > > Steve > > _______________________________________________ > > gem5-dev mailing list > > [email protected] > > http://m5sim.org/mailman/listinfo/gem5-dev > > > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
