----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3415/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11417:214335b48cb4 --------------------------- ruby: remove unused code inside '#if 0 ... #endif' The code looks stale - `hg blame` shows that the lines were last modified by Nate in 2010 for style issues. I sincerely doubt that anyone has used it since it was originally written. Furthermore, the code will not even compile if the preprocessor directives are removed; the llocker and uulocker variables that are used as indices into the persistent_randomize array are undefined. It's not clear what they should be from the current code. Diffs ----- src/mem/ruby/structures/PersistentTable.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca Diff: http://reviews.gem5.org/r/3415/diff/ Testing ------- Thanks, Brandon Potter _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
