----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3420/#review8140 -----------------------------------------------------------
Ship it! src/mem/ruby/filters/MultiBitSelBloomFilter.hh (line 84) <http://reviews.gem5.org/r/3420/#comment7014> Why this change? isParallel is what the style guide says, not m_*. Couple of small notes, but other than that it's fine. Any idea why it was originally like this? Seems kinda crazy. - Jason Lowe-Power On April 4, 2016, 11:39 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3420/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 11:39 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11422:6fc675f956dc > --------------------------- > ruby: change MultiBitSelBlockFilter constructor signature > > The previous format required a string which was then tokenized to retrieve > the constructor arguments. The string is removed and the arguments are > passed directly in their correct format. > > > Diffs > ----- > > src/mem/ruby/filters/MultiBitSelBloomFilter.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/filters/MultiBitSelBloomFilter.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > > Diff: http://reviews.gem5.org/r/3420/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
