> On April 5, 2016, 2:54 p.m., Jason Lowe-Power wrote: > > Would you be against doing if (count > 0)? I think that is more clear than > > a static cast.
The two m_map objects are an unordered_map and an ordered_map. The count method can only return 0 or 1 because duplicates are not allowed in the maps. So, I think that I will drop the explicit cast and let it happen implicitly. (Not sure what the motivation was for doing the C-style explicit cast.) - Brandon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3414/#review8138 ----------------------------------------------------------- On April 4, 2016, 11:38 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3414/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 11:38 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11416:ce9c6632223b > --------------------------- > ruby: change !! into static_cast<bool> calls > > > Diffs > ----- > > src/mem/ruby/structures/TBETable.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/TimerTable.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > > Diff: http://reviews.gem5.org/r/3414/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
