> On April 6, 2016, 9:39 p.m., Andreas Hansson wrote: > > Could you explain why? > > > > In general, for all of these patches, could you please add a brief > > description of the "why"?
The diatribe that I just posted on http://reviews.gem5.org/r/3428/ should give enough insight into why we need to modify the stats framework. Again, somebody decided to use statics to aggregate statistics acrosss a controller type and the result is that it doesn't work for multiple systems. Nilay wrote this code which allows the controller statistics to be aggregated per system at the end of a simulation. - Brandon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3432/#review8151 ----------------------------------------------------------- On April 4, 2016, 11:43 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3432/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 11:43 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11434:859f55d0928e > --------------------------- > base: stats: add function for printing text to output > > This patch overloads the function visit() associated with Output class so that > one can output a string. > > > Diffs > ----- > > src/base/stats/info.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/base/stats/output.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/base/stats/text.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/base/stats/text.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > > Diff: http://reviews.gem5.org/r/3432/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev