> On April 11, 2016, 8:51 p.m., Jason Lowe-Power wrote: > > Could you point out where this parameter is used? I'm having a hard time > > finding it in this patch. > > > > Without seeing where the parameter is used, I feel like there has to be a > > better way! Surely we can find a way to modify the few places this > > information is needed rather than changing every file.
Seems I jumped the gun here. This, /r/3423 and /r/3424 will be combined? To double check that I understand, the reason this is needed is for makeLineAddress, etc? Could you provide a list of these functions? Maybe we should take this off reviewboard. Could you send an email with the underlying reason you need to pass this new parameter around everywhere. Since it's split across so many patches, I'm having a hard time following. I really don't like the idea of passing around this parameter everywhere. I'd like to understand better the problem so I can try my hand at a cleaner solution. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3422/#review8178 ----------------------------------------------------------- On April 4, 2016, 11:40 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3422/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 11:40 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11424:6901103f7f04 > --------------------------- > ruby: change function signature for functional_read/write > > The functional_read and function_write functions within Ruby will > occasionally use methods which rely on knowing the block size so we add > the block size as a parameter. > > To avoid special casing large sections of the SLICC code, we propagate the > change to all instances of these functions (even when the parameter is > not used). > > > Diffs > ----- > > src/mem/ruby/slicc_interface/Message.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/slicc_interface/RubyRequest.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/slicc_interface/RubyRequest.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/RubySystem.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/slicc/symbols/StateMachine.py > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/flexible-pipeline/flitBuffer.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/flexible-pipeline/flitBuffer.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/simple/SimpleNetwork.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/simple/SimpleNetwork.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/simple/Switch.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/simple/Switch.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/flit_d.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/flexible-pipeline/Router.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/flexible-pipeline/Router.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/flexible-pipeline/flit.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/flexible-pipeline/flit.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/VirtualChannel_d.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/VirtualChannel_d.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/flitBuffer_d.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/flitBuffer_d.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/flit_d.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/MESI_Three_Level-msg.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/MESI_Two_Level-msg.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/MI_example-msg.sm cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/MOESI_AMD_Base-Region-msg.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/MOESI_AMD_Base-msg.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/MOESI_CMP_directory-msg.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/MOESI_CMP_token-msg.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/MOESI_hammer-msg.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/Network_test-msg.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/RubySlicc_Exports.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/protocol/RubySlicc_MemControl.sm > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/MessageBuffer.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/MessageBuffer.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/Network.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > > Diff: http://reviews.gem5.org/r/3422/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
