----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3446/#review8191 -----------------------------------------------------------
Ship it! Thanks! - Andreas Hansson On April 12, 2016, 5:20 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3446/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 5:20 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11443:3e0817967515 > --------------------------- > hsail,gpu-compute: fixes to appease clang++ > > fixes to appease clang++. tested on Ubuntu clang version > 3.5.0-4ubuntu2~trusty2 (tags/RELEASE_350/final) (based on > LLVM 3.5.0) > > the fixes address the following two issues: > > 1) the exec continuations in gpu_static_inst.hh were marked > as protected when they should be public. here we mark > them as public > > 2) the Abs instruction uses std::abs() in its execute method. > because Abs is templated, it can also operate on U32 and U64, > types, which cause Abs::execute() to pass uint32_t and uint64_t > types to std::abs() respectively. this triggers a warning > because std::abs() has no effect in this case. to rememdy this > we add template specialization for the execute() method of Abs > when its template paramter is U32 or U64. > > > Diffs > ----- > > src/arch/hsail/gen.py b31738224fb0eb259efc25f6d6efab5a962f29d0 > src/gpu-compute/gpu_static_inst.hh b31738224fb0eb259efc25f6d6efab5a962f29d0 > > Diff: http://reviews.gem5.org/r/3446/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
