> On April 13, 2016, 4:58 p.m., Joel Hestness wrote: > > src/mem/ruby/network/MessageBuffer.hh, line 40 > > <http://reviews.gem5.org/r/3442/diff/1/?file=54830#file54830line40> > > > > Not a big deal, but in general, these sorts of changes should be in a > > separate patch.
Agreed. I did ask for 32 reviews at once though. :P > On April 13, 2016, 4:58 p.m., Joel Hestness wrote: > > src/mem/ruby/system/RubyPort.cc, line 181 > > <http://reviews.gem5.org/r/3442/diff/1/?file=54845#file54845line181> > > > > I think this is actually a bug, and fixing it would clean things up: A > > RubyPort's ports should be clocked at the same frequency as the RubyPort > > itself, rather than the RubySystem frequency. Can we just change these to > > rp->clockPeriod() throughout this file and eliminate the RubySystem > > indirection in these functions? Fixed the issue by opening this: http://reviews.gem5.org/r/3451/ - Brandon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3442/#review8203 ----------------------------------------------------------- On April 4, 2016, 11:45 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3442/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 11:45 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11444:aaafbce03017 > --------------------------- > ruby: allows multiple instances of ruby to be invoked > > This patch removes the restriction that there can only be a single ruby > system object in a given simulation. With the configuration supplied, it is > possible to run an instance of ruby with any of the supplied topologies. > > > Diffs > ----- > > src/mem/ruby/system/Sequencer.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/Sequencer.py cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/slicc_interface/AbstractController.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/slicc_interface/AbstractController.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/slicc_interface/Controller.py > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/BankedArray.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/BankedArray.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/structures/TimerTable.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/RubyPort.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/RubyPort.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/RubySystem.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/RubySystem.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/system/Sequencer.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/MessageBuffer.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/MessageBuffer.py > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/Network.py cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/simple/Throttle.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/network/simple/Throttle.cc > cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/profiler/Profiler.hh cfad34a15729e1d5e096245f5a80ded6e2c379ca > src/mem/ruby/profiler/Profiler.cc cfad34a15729e1d5e096245f5a80ded6e2c379ca > configs/example/multi-system-apu.py PRE-CREATION > configs/example/multi-system-se.py PRE-CREATION > src/mem/ruby/network/MessageBuffer.hh > cfad34a15729e1d5e096245f5a80ded6e2c379ca > > Diff: http://reviews.gem5.org/r/3442/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
