-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3447/#review8246
-----------------------------------------------------------


I tried this on a couple of different linux kernels and boot went fine. Is 
there something else I can test to make sure this code gets executed?

- Jason Lowe-Power


On April 13, 2016, 2:12 p.m., Bjoern A. Zeeb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3447/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 2:12 p.m.)
> 
> 
> Review request for Default, Jason Lowe-Power and Steve Reinhardt.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> x86, dev: properly space the APIC registers
> 
> Registers are 0x10 and not 0x8 apart.  The latter leads to invalid 
> calculations of index in array which in turn means that we will not find the 
> interrupt we were looking (been notified) for in the OS.
> 
> 
> Diffs
> -----
> 
>   src/arch/x86/interrupts.cc 9c7b55faea5d 
> 
> Diff: http://reviews.gem5.org/r/3447/diff/
> 
> 
> Testing
> -------
> 
> Testing done on FreeBSD amd64 FS boot.
> Testing not done for Linux.
> 
> 
> Thanks,
> 
> Bjoern A. Zeeb
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to