> On April 26, 2016, 10:54 p.m., Bjoern A. Zeeb wrote:
> > This was fixed in HEAD after I noticed that we aren't spec compliant; but
> > older versions indeed need the cast.
> >
> > I am currently using at least an #ifdef here:
> >
> > --- a/src/sim/init_signals.cc Tue Apr 05 08:08:12 2016 -0500
> > +++ b/src/sim/init_signals.cc Tue Apr 26 20:51:26 2016 +0000
> > @@ -66,7 +66,11 @@
> > setupAltStack()
> > {
> > stack_t stack;
> > +#ifdef __FreeBSD__
> > + stack.ss_sp = (char *)fatalSigStack;
> > +#else
> > stack.ss_sp = fatalSigStack;
> > +#endif
> > stack.ss_size = sizeof(fatalSigStack);
> > stack.ss_flags = 0;
> >
> > But for the FreeBSD block we almost also need to check __FreeBSD_version >=
> > 11xxxxxx but I haven't done the due diligence yet what the exact version
> > number should be.
>
> Bjoern A. Zeeb wrote:
> https://svnweb.freebsd.org/base?view=revision&revision=294930
>
> PS: this has nothing to do with clang really.
Where was it fixed ? There is no changes in HEAD in init_signals.cc
BTW, I am using HEAD.
- Pierre-Yves
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3454/#review8274
-----------------------------------------------------------
On April 26, 2016, 8:02 p.m., Pierre-Yves Péneau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3454/
> -----------------------------------------------------------
>
> (Updated April 26, 2016, 8:02 p.m.)
>
>
> Review request for Default.
>
>
> Repository: gem5
>
>
> Description
> -------
>
> Appease clang-3.4.1
>
>
> Diffs
> -----
>
> src/sim/init_signals.cc e41eca4aecbb
>
> Diff: http://reviews.gem5.org/r/3454/diff/
>
>
> Testing
> -------
>
> Fresh install of FreeBSD 10.3-RELEASE (i386), default clang compiler (3.4.1)
>
>
> Thanks,
>
> Pierre-Yves Péneau
>
>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
