Hi Jyothish,

Thanks for the contribution! Could you post this patch to the reviewboard
site? http://reviews.gem5.org/

Take a look at http://gem5.org/Submitting_Contributions to see how to
submit to reviewboard and the required commit message formatting.

As a quick first pass review, it seems to me that the solution should
simply change two lines (and similarly for the lq).

- if (!sqFull(tid))
-     return false;
+ return thread[tid].sqFull();

I could be wrong, though.

Thanks again for contributing!

Cheers,
Jason


On Sat, May 14, 2016 at 5:02 AM Jyothish Soman <[email protected]>
wrote:

> Hi,
>
> There is an infinite loop in lsq_impl.hh lines 621, 608 related to the
> dynamic thread policy.
>
> Substituting a simple function that counted usage fixed it.
>
> I have added a rudimentary diff here in case someone wants a quick fix.
>
>
> Best,
> Jyothish
> _______________________________________________
> gem5-dev mailing list
> [email protected]
> http://m5sim.org/mailman/listinfo/gem5-dev
>
-- 

Jason
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to