> On June 4, 2016, 2:46 p.m., Andreas Hansson wrote: > > ext/mc2lib/contrib/mcversi/m5_host_support.h, line 124 > > <http://reviews.gem5.org/r/3448/diff/5/?file=55665#file55665line124> > > > > should we just get it done rather? > > Marco Elver wrote: > Cache flushing is not essential, but recommended (see note about x86 > clflush). It would be nice to have, but at the moment I don't have time to > chase up on how to implement this for ARMv7 (contributions welcome!). > > Note that even without this, I'm able to find a rather hard to find bug > in ARM+Classic (see > http://www.mail-archive.com/[email protected]/msg18940.html ). > > Andreas Hansson wrote: > Could you elaborate on what it has to accomplish (to make it easier for > someone to actually fill in the blanks)?
It should invalidate the cache line that contains the specified address from *all* levels of the cache hierarchy and any other buffer. I looked into this a while ago, and found that flushing the D-cache only is easy enough. It seems to get hairy when wanting to invalidate lower levels as well (L2, L3, ... Ln). - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3448/#review8395 ----------------------------------------------------------- On June 4, 2016, 3:42 p.m., Marco Elver wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3448/ > ----------------------------------------------------------- > > (Updated June 4, 2016, 3:42 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Add mc2lib to ext/ > > This is the simulator-independent component for McVerSi. > > Source: https://github.com/melver/mc2lib > > > Diffs > ----- > > ext/mc2lib/LICENSE PRE-CREATION > ext/mc2lib/README.rst PRE-CREATION > ext/mc2lib/SConscript PRE-CREATION > ext/mc2lib/_UPSTREAM PRE-CREATION > ext/mc2lib/contrib/mcversi/README.rst PRE-CREATION > ext/mc2lib/contrib/mcversi/guest_workload.c PRE-CREATION > ext/mc2lib/contrib/mcversi/host_support.h PRE-CREATION > ext/mc2lib/contrib/mcversi/m5_host_support.h PRE-CREATION > ext/mc2lib/contrib/mcversi/run-10-8KB-1synonym.sh PRE-CREATION > ext/mc2lib/contrib/mcversi/run-10-8KB.sh PRE-CREATION > ext/mc2lib/include/mc2lib/codegen/cats.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/codegen/compiler.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/codegen/ops/armv7.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/codegen/ops/strong.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/codegen/ops/x86_64.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/codegen/rit.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/mcversi.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/memconsistency/cats.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/memconsistency/eventsets.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/memconsistency/model12.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/sets.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/simplega.hpp PRE-CREATION > ext/mc2lib/include/mc2lib/types.hpp PRE-CREATION > SConstruct e18a6c55bec0 > > Diff: http://reviews.gem5.org/r/3448/diff/ > > > Testing > ------- > > Together with http://reviews.gem5.org/r/3449/ > > > Thanks, > > Marco Elver > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
