----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3542/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- cpu: Fix Minor SMT WFI/drain interaction issues The behavior of WFI is to cause minor to cease evaluating pipeline logic until an interrupt is observed, however a user may wish to drain the system while a core is sleeping due to a WFI. This patch makes WFI drain. If an actual drain occurs during a WFI, the CPU is already drained and will immediately be ready for swapping, checkpointing, etc. This should not negatively impact performance as WFI instructions are 'stream-changing' (treated like unpredicted branches), so all remaining instructions are wrong-path and will be squashed rapidly. Diffs ----- src/cpu/minor/decode.cc dd6dfd38b6c2a37be9503db68eb1e816ee08e609 src/cpu/minor/execute.cc dd6dfd38b6c2a37be9503db68eb1e816ee08e609 src/cpu/minor/fetch1.cc dd6dfd38b6c2a37be9503db68eb1e816ee08e609 src/cpu/minor/fetch2.cc dd6dfd38b6c2a37be9503db68eb1e816ee08e609 Diff: http://reviews.gem5.org/r/3542/diff/ Testing ------- Thanks, Curtis Dunham _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
