----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3561/#review8492 -----------------------------------------------------------
Ship it! Ship It! - Tony Gutierrez On July 12, 2016, 12:15 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3561/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 12:15 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11563:7bdfd47d54da > --------------------------- > mem: Update mostly exclusive policy even further > > This patch takes yet another step in maintaining the clusivity, in > that it allows a mostly-inclusive cache to hold on to blocks even when > responding to a ReadExReq or UpgradeReq. Previously the cache simply > invalidated these blocks, but there is no strict need to do so. > > The most important part of this patch is that we simply mark the block > clean when satisfying the upstream request where the cache is allowed > to keep the block. The only tricky part of the patch is in the memory > management of deferred snoops, where we need to distinguish the cases > where only the packet was copied (we expected to respond), and the > cases where we created an entirely new packet and request (we kept it > only to replay later). > > The code in satisfyRequest is definitely ready for some refactoring > after this. > > Change-Id: I201ddc7b2582eaa46fb8cff0c7ad09e02d64b0fc > Reviewed-by: Nikos Nikoleris <nikos.nikole...@arm.com> > > > Diffs > ----- > > src/mem/cache/cache.cc f050b8cf4754 > > Diff: http://reviews.gem5.org/r/3561/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
