> On June 30, 2016, 7:17 a.m., Andreas Hansson wrote: > > src/gpu-compute/wavefront.hh, line 389 > > <http://reviews.gem5.org/r/3535/diff/1/?file=56852#file56852line389> > > > > Surely one of these should be const
I do not see this being addressed. getContext should be const I would imagine. > On June 30, 2016, 7:17 a.m., Andreas Hansson wrote: > > src/gpu-compute/wavefront.cc, line 946 > > <http://reviews.gem5.org/r/3535/diff/1/?file=56853#file56853line946> > > > > Not too many bonus points for comments here...that's for sure. > > Alexandru Dutu wrote: > I have added a comment in the header file which should describe the > behaviour of this method and added comments inside it where things are not > straight forward (i.e. recovergence stack and LDS). Please let me know what > is not clear and requires a comment, would be happy to add some more. I find the code rather unfortunate. It would have been great to see this implemented using e.g. protobuf or similar, but it's up to you if you really think this is maintainable (and understandable). - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3535/#review8452 ----------------------------------------------------------- On July 8, 2016, 10:14 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3535/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 10:14 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11556:9e4c3b188fc5 > --------------------------- > gpu-compute: Adding context serialization methods to Wavefront > > This patch adds methods to serialize the context of a particular wavefront > to the simulated system memory. Context serialization is used when a wavefront > is preempeted (i.e. context switch). > > > Diffs > ----- > > src/gpu-compute/wavefront.hh 91f58918a76abf1a1dedcaa70a9b95789da7b88c > src/gpu-compute/wavefront.cc 91f58918a76abf1a1dedcaa70a9b95789da7b88c > > Diff: http://reviews.gem5.org/r/3535/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
