> On Aug. 8, 2016, 8:16 a.m., Andreas Hansson wrote: > > src/sim/syscall_emul.hh, line 305 > > <http://reviews.gem5.org/r/3583/diff/2/?file=57465#file57465line305> > > > > whitespace here and a few other places > > > > is your editor setup correctly? > > Nicolas Derumigny wrote: > My bad, I left some whitespace du to auto spacing, It's corrected now. > Sorry, I do not have some OSX computer to test with right now, how can I test > ? I can put preprocessor directives to let it run only on linux.
Andreas, how do you suggest those of us without access to OSX test the compile? I agree this is important since many of our developers seem to use Macs, but it is also a little much to ask for all of us to go out and buy a Mac to make sure gem5 compiles. From what I can tell online, it's of questionable legality to run an OSX image in vmware or other virutalization systems. Any ideas? - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3583/#review8583 ----------------------------------------------------------- On Aug. 8, 2016, 9:18 a.m., Nicolas Derumigny wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3583/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2016, 9:18 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > syscall_emul: Added getdents and getdents64 syscalls > > > Diffs > ----- > > src/arch/x86/linux/process.cc ba45735a726a > src/sim/syscall_emul.hh ba45735a726a > src/sim/syscall_emul.cc ba45735a726a > > Diff: http://reviews.gem5.org/r/3583/diff/ > > > Testing > ------- > > Works with readdir() wrapper, tested with CERE codelets > (https://github.com/benchmark-subsetting/cere). > > > Thanks, > > Nicolas Derumigny > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
