----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3558/#review8721 -----------------------------------------------------------
Ship it! Looks good overall. configs/topologies/Mesh_westfirst.py (line 106) <http://reviews.gem5.org/r/3558/#comment7533> white space configs/topologies/Pt2Pt.py (line 51) <http://reviews.gem5.org/r/3558/#comment7534> white space src/mem/ruby/network/garnet2.0/SwitchAllocator.cc (line 293) <http://reviews.gem5.org/r/3558/#comment7535> white space src/mem/ruby/network/garnet2.0/SwitchAllocator.cc (line 299) <http://reviews.gem5.org/r/3558/#comment7536> empty line src/mem/ruby/network/garnet2.0/SwitchAllocator.cc (line 317) <http://reviews.gem5.org/r/3558/#comment7537> empty line src/mem/ruby/network/garnet2.0/SwitchAllocator.cc (line 321) <http://reviews.gem5.org/r/3558/#comment7538> white space - Jieming Yin On Aug. 24, 2016, 3:24 p.m., Tushar Krishna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3558/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2016, 3:24 p.m.) > > > Review request for Default, Andreas Hansson, Brad Beckmann, Jieming Yin, and > Matthew Poremba. > > > Repository: gem5 > > > Description > ------- > > ruby: garnet2.0 > Revamped version of garnet with more optimized single-cycle routers, > more configurability, and cleaner code. > > > Diffs > ----- > > src/mem/ruby/network/garnet2.0/GarnetLink.py PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetNetwork.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetNetwork.cc PRE-CREATION > configs/topologies/Crossbar.py d726d0cea027 > configs/topologies/MeshDirCorners_XY.py PRE-CREATION > configs/topologies/Mesh_XY.py PRE-CREATION > configs/topologies/Mesh_westfirst.py PRE-CREATION > configs/topologies/Pt2Pt.py d726d0cea027 > src/base/statistics.cc d726d0cea027 > src/mem/ruby/network/BasicRouter.py d726d0cea027 > src/mem/ruby/network/garnet2.0/CommonTypes.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/Credit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/Credit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/CreditLink.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/CrossbarSwitch.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/CrossbarSwitch.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetLink.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetLink.cc PRE-CREATION > configs/network/Network.py PRE-CREATION > src/mem/ruby/network/garnet2.0/Router.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/RoutingUnit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/RoutingUnit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/SConscript PRE-CREATION > src/mem/ruby/network/garnet2.0/SwitchAllocator.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/SwitchAllocator.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/VirtualChannel.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/VirtualChannel.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/flit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/flit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/flitBuffer.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/flitBuffer.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/OutputUnit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/OutputUnit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/README.txt PRE-CREATION > src/mem/ruby/network/garnet2.0/Router.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/NetworkLink.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/OutVcState.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/OutVcState.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/NetworkLink.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetNetwork.py PRE-CREATION > src/mem/ruby/network/garnet2.0/InputUnit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/InputUnit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/NetworkInterface.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/NetworkInterface.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3558/diff/ > > > Testing > ------- > > > Thanks, > > Tushar Krishna > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
