> On Aug. 16, 2016, 3:15 p.m., Jason Lowe-Power wrote: > > src/mem/dram_ctrl.cc, line 1928 > > <http://reviews.gem5.org/r/3601/diff/1/?file=57419#file57419line1928> > > > > Should this be here? Or in the constructor or ::init()? > > > > I'm not sure where the right place is.. but I don't think that > > regStats() is it. I think it's kind of hidden here. > > Wendy Elsasser wrote: > It was placed here as it's used to update the power / energy values each > time statistics are dumped during a simulation to include values up to that > point. > > While it may be hidden, it is providing the right function. Comments?
Sure. I just looked it up in the current codebase. In Ruby all of the registerDumpCallback calls are in the constructor, but there are 3 other instances of this function and they are all in regStats(). So, keeping it where you have it is following some convention ;). Leaving it this way is fine with me. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3601/#review8638 ----------------------------------------------------------- On Aug. 11, 2016, 9:08 a.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3601/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2016, 9:08 a.m.) > > > Review request for Default and Matthias Jung. > > > Repository: gem5 > > > Description > ------- > > mem: Add callback to compute stats prior to dump event > > The per rank statistics are periodically updated based on > state transition and refresh events. > > Add a method to update these when a dump event occurs to > ensure they reflect accurate values. > Specifically, need to ensure that the low-power state > durations, power, and energy are logged correctly. > > Change-Id: Ib642a6668340de8f494a608bb34982e58ba7f1eb > Reviewed-by: Radhika Jagtap <radhika.jag...@arm.com> > > > Diffs > ----- > > src/mem/dram_ctrl.cc e9096175eb38ac39f37c91bfdf2a450b9664e222 > src/mem/dram_ctrl.hh e9096175eb38ac39f37c91bfdf2a450b9664e222 > > Diff: http://reviews.gem5.org/r/3601/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
