----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3635/#review8766 -----------------------------------------------------------
Ship it! src/base/remote_gdb.cc (line 253) <http://reviews.gem5.org/r/3635/#comment7584> Could you make this a bit more descriptive before submitting it? Something like "A GDB trap event has already been scheduled, ignoring second event." No need for a second review though. - Andreas Sandberg On Oct. 3, 2016, 8:49 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3635/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2016, 8:49 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11654:46ce6e3222ec > --------------------------- > misc: Adds a warning in case gdb is attached multiple times > Instead of scheduling another event, this patch adds a warning in case gdb > is attached multiple times and the first attachement event has not been > processed yet. > > > Diffs > ----- > > src/base/remote_gdb.cc 2c111e634da005e2b78981fadd0368662454f2ed > > Diff: http://reviews.gem5.org/r/3635/diff/ > > > Testing > ------- > > Regressions pass. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
