> On Oct. 7, 2016, 2:15 p.m., Jason Lowe-Power wrote: > > configs/ruby/Ruby.py, line 50 > > <http://reviews.gem5.org/r/3647/diff/1/?file=58365#file58365line50> > > > > I think I'm missing something, but isn't the network directory and the > > topologies directory both in configs/? Why are these addToPath calls > > different? > > Andreas Hansson wrote: > Excellent question. I think the topology line is acually both wrong and > unnecessary. > > I really must confess the current behaviuor of addToPath is a bit of a > mystery (what is it really relative to), and it turns out it is relative to > the run.py script in the test folder.
Thanks for the info. I agree about addToPath :). - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3647/#review8780 ----------------------------------------------------------- On Oct. 7, 2016, 9:40 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3647/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2016, 9:40 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11668:fd9c744bac8b > --------------------------- > ruby: Fix broken regressions > > This patch moves the addition of network options into the Ruby module > to avoid the regressions all having to add it explicitly. The example > scripts are also updated. > > > Diffs > ----- > > configs/ruby/Ruby.py ebf2acd02fc5 > configs/example/ruby_random_test.py ebf2acd02fc5 > configs/example/se.py ebf2acd02fc5 > configs/example/ruby_direct_test.py ebf2acd02fc5 > configs/example/ruby_gpu_random_test.py ebf2acd02fc5 > configs/example/ruby_mem_test.py ebf2acd02fc5 > configs/example/apu_se.py ebf2acd02fc5 > configs/example/fs.py ebf2acd02fc5 > configs/example/garnet_synth_traffic.py ebf2acd02fc5 > > Diff: http://reviews.gem5.org/r/3647/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
