> On Oct. 7, 2016, 10:31 a.m., Andreas Sandberg wrote: > > Thanks for doing this! This is something that has annoyed me for quite some > > time as well. > > > > Thee are quite a few files modified in patch where the header order isn't > > compliant with the style guide, which is probably why you are seeing style > > checker errors. Ideally, I'd like to see the primary header first rule > > enforced in all CC files since that ensures that header files include all > > of their dependencies, but I wouldn't say that's a blocker.
I have just added the necessary fixes to the style checker to automate this (see [RB3648](http://reviews.gem5.org/r/3648/)). We (I'm happy to do it) should be able to fix the include order automagically using this: ```` ./util/style.py -f -c SortedIncludes `find src/ -name *.cc` ```` - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3643/#review8779 ----------------------------------------------------------- On Oct. 5, 2016, 5:27 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3643/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 5:27 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11660:1c76ab8bafec > --------------------------- > style: reduce include dependencies in some headers > > > Diffs > ----- > > src/arch/x86/system.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/x86/tlb.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/x86/tlb.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/x86/utility.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/x86/utility.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/kern/linux/linux.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/kern/linux/linux.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/mem/multi_level_page_table.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/mem/multi_level_page_table_impl.hh > b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/mem/page_table.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/mem/page_table.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/sim/arguments.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/sim/process.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/sim/process.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/sim/sim_object.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/sim/sim_object.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/sim/syscall_emul.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/sim/syscall_emul.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/generic/tlb.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/power/interrupts.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/x86/pagetable.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/x86/pagetable.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/x86/pseudo_inst.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > src/arch/x86/system.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 > > Diff: http://reviews.gem5.org/r/3643/diff/ > > > Testing > ------- > > util/regress > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
