You can reproduce the error if you run apu_se.py by hand. For example: # build the HSAIL GPU scons -jN ./build/HSAIL_X86/gem5.opt
# run the GPU hello test ./build/HSAIL_X86/gem5.opt configs/example/apu_se.py -c tests/test-progs/gpu-hello/bin/x86/linux/gpu-hello -k tests/test-progs/gpu-hello/bin/x86/linux/gpu-hello-kernel.asm -----Original Message----- From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Krishna, Tushar Sent: Friday, October 07, 2016 3:26 PM To: gem5 Developer List <gem5-dev@gem5.org> Subject: Re: [gem5-dev] Review Request 3647: ruby: Fix broken regressions Hi Brandon, SimpleIntLink inherits from BasicIntLink (which defines dst_node) so this error shouldn’t ideally show up. I don’t see it when I run the simple network. Can you tell me what command you ran? I’ll try reproducing and debugging it on my end. Cheers, Tushar > On Oct 7, 2016, at 6:15 PM, Andreas Hansson <andreas.hans...@arm.com> wrote: > > > >> On Oct. 7, 2016, 10:04 p.m., Brandon Potter wrote: >>> I'm noticing that this patch doesn't completely fix the regressions on its >>> own. There are still two failures that I'm seeing with it applied (although >>> they may be unrelated, not sure): >>> >>> `cat >>> build/HSAIL_X86/tests/opt/quick/se/04.gpu/x86/linux/gpu-ruby-GPU_RfO >>> /simerr` >>> >>> warn: add_child('dst_node_'): child 'int_node' already has parent >>> warn: add_child('dst_node_'): child 'int_node' already has parent >>> warn: add_child('dst_node_'): child 'int_node' already has parent >>> warn: add_child('dst_node_'): child 'dst_node_' already has parent >>> Traceback (most recent call last): >>> File "<string>", line 1, in <module> File >>> "/home/bpotter/Research/gem5/gem5-public-process/src/python/m5/main.py", >>> line 400, in main >>> exec filecode in scope >>> File >>> "/home/bpotter/Research/gem5/gem5-public-process/tests/testing/../run.py", >>> line 184, in <module> >>> execfile(joinpath(tests_root, 'configs', test_filename + '.py')) >>> File >>> "/home/bpotter/Research/gem5/gem5-public-process/tests/testing/../configs/gpu-ruby.py", >>> line 282, in <module> >>> Ruby.create_system(options, None, system) File >>> "/home/bpotter/Research/gem5/gem5-public-process/configs/ruby/Ruby.py", >>> line 175, in create_system >>> Network.init_network(options, network, InterfaceClass) File >>> "/home/bpotter/Research/gem5/gem5-public-process/configs/network/Network.py", >>> line 108, in init_network >>> network.setup_buffers() >>> File >>> "/home/bpotter/Research/gem5/gem5-public-process/src/mem/ruby/network/simple/SimpleNetwork.py", >>> line 62, in setup_buffers >>> if link.dst_node == router: >>> File >>> "/home/bpotter/Research/gem5/gem5-public-process/src/python/m5/SimObject.py", >>> line 1105, in __getattr__ >>> raise AttributeError, err_string >>> AttributeError: object 'SimpleIntLink' has no attribute 'dst_node' >>> (C++ object is not yet constructed, so wrapped C++ methods are >>> unavailable.) >>> >>> `cat >>> build/HSAIL_X86/tests/opt/quick/se/60.gpu-randomtest/x86/linux/gpu-r >>> andomtest-ruby-GPU_RfO/simerr` >>> >>> warn: add_child('dst_node_'): child 'int_node' already has parent >>> warn: add_child('dst_node_'): child 'int_node' already has parent >>> warn: add_child('dst_node_'): child 'int_node' already has parent >>> warn: add_child('dst_node_'): child 'dst_node_' already has parent >>> Traceback (most recent call last): >>> File "<string>", line 1, in <module> File >>> "/home/bpotter/Research/gem5/gem5-public-process/src/python/m5/main.py", >>> line 400, in main >>> exec filecode in scope >>> File >>> "/home/bpotter/Research/gem5/gem5-public-process/tests/testing/../run.py", >>> line 184, in <module> >>> execfile(joinpath(tests_root, 'configs', test_filename + '.py')) >>> File >>> "/home/bpotter/Research/gem5/gem5-public-process/tests/testing/../configs/gpu-randomtest-ruby.py", >>> line 104, in <module> >>> Ruby.create_system(options, False, system) File >>> "/home/bpotter/Research/gem5/gem5-public-process/configs/ruby/Ruby.py", >>> line 175, in create_system >>> Network.init_network(options, network, InterfaceClass) File >>> "/home/bpotter/Research/gem5/gem5-public-process/configs/network/Network.py", >>> line 108, in init_network >>> network.setup_buffers() >>> File >>> "/home/bpotter/Research/gem5/gem5-public-process/src/mem/ruby/network/simple/SimpleNetwork.py", >>> line 62, in setup_buffers >>> if link.dst_node == router: >>> File >>> "/home/bpotter/Research/gem5/gem5-public-process/src/python/m5/SimObject.py", >>> line 1105, in __getattr__ >>> raise AttributeError, err_string >>> AttributeError: object 'SimpleIntLink' has no attribute 'dst_node' >>> (C++ object is not yet constructed, so wrapped C++ methods are >>> unavailable.) > > I would think this is "unrelated" in that it has nothing to do with the > import of Network. > > > - Andreas > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3647/#review8790 > ----------------------------------------------------------- > > > On Oct. 7, 2016, 5:29 p.m., Andreas Hansson wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.gem5.org/r/3647/ >> ----------------------------------------------------------- >> >> (Updated Oct. 7, 2016, 5:29 p.m.) >> >> >> Review request for Default. >> >> >> Repository: gem5 >> >> >> Description >> ------- >> >> Changeset 11668:8816ebf0a103 >> --------------------------- >> ruby: Fix broken regressions >> >> This patch moves the addition of network options into the Ruby module >> to avoid the regressions all having to add it explicitly. The example >> scripts are also updated, and the messy path-deducing variations in >> the scripts are unified. >> >> >> Diffs >> ----- >> >> tests/configs/gpu-randomtest-ruby.py ebf2acd02fc5 >> tests/configs/gpu-ruby.py ebf2acd02fc5 tests/configs/memtest-ruby.py >> ebf2acd02fc5 tests/configs/o3-timing-mp-ruby.py ebf2acd02fc5 >> tests/configs/o3-timing-ruby.py ebf2acd02fc5 >> tests/configs/pc-simple-timing-ruby.py ebf2acd02fc5 >> tests/configs/rubytest-ruby.py ebf2acd02fc5 >> tests/configs/simple-atomic-mp-ruby.py ebf2acd02fc5 >> tests/configs/simple-timing-mp-ruby.py ebf2acd02fc5 >> tests/configs/simple-timing-ruby.py ebf2acd02fc5 >> configs/example/apu_se.py ebf2acd02fc5 configs/example/fs.py >> ebf2acd02fc5 configs/example/garnet_synth_traffic.py ebf2acd02fc5 >> configs/example/ruby_direct_test.py ebf2acd02fc5 >> configs/example/ruby_gpu_random_test.py ebf2acd02fc5 >> configs/example/ruby_mem_test.py ebf2acd02fc5 >> configs/example/ruby_random_test.py ebf2acd02fc5 >> configs/example/se.py ebf2acd02fc5 configs/ruby/Ruby.py ebf2acd02fc5 >> >> Diff: http://reviews.gem5.org/r/3647/diff/ >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Andreas Hansson >> >> > > _______________________________________________ > gem5-dev mailing list > gem5-dev@gem5.org > http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
