----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3674/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11696:c48d378a972a --------------------------- syscall_emul: [patch 8/22] refactor process class Moves aux_vector into its own .hh and .cc files just to get it out of the already crowded Process files. Arguably, it could stay there, but it's probably better just to move it and give it files. The changeset looks ugly around the Process header file, but the goal here is to move methods and members around so that they're not defined randomly throughout the entire header file. I expect this is likely one of the reasons why I several unused variables related to this class. So, the methods are declared first followed by members. I've tried to aggregate them together so that similar entries reside near one another. There are other changes coming to this code so this is by no means the final product. Diffs ----- src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/aux_vector.cc PRE-CREATION src/sim/aux_vector.hh PRE-CREATION src/sim/SConscript 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/x86/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/sparc/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/power/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/mips/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/arm/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3674/diff/ Testing ------- Thanks, Brandon Potter _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
