----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3670/#review8873 -----------------------------------------------------------
src/sim/process.cc <http://reviews.gem5.org/r/3670/#comment7629> Even if we are serializing nextPid in the System object, shouldn't we still serialize _pid? We might need to have the same pids restored and not reassign different ones. src/sim/process.cc <http://reviews.gem5.org/r/3670/#comment7630> Same goes for unserialization. - Alexandru Dutu On Oct. 17, 2016, 3:14 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3670/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2016, 3:14 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11692:ba60e4ae816f > --------------------------- > syscall_emul: [patch 4/22] remove redundant M5_pid field from process > > > Diffs > ----- > > src/sim/system.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/system.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/process.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/Process.py 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/sparc/faults.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/alpha/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > > Diff: http://reviews.gem5.org/r/3670/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
