----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3527/#review8988 -----------------------------------------------------------
Thanks for this. There are a few minor issues and style questions. util/tlm/Makefile (line 4) <http://reviews.gem5.org/r/3527/#comment7717> Just add the additional Copyright line before "All rights reserved." util/tlm/Makefile (line 10) <http://reviews.gem5.org/r/3527/#comment7718> Please avoid changing whitespace (even if it is wrong). That should be done separately. util/tlm/Makefile (line 35) <http://reviews.gem5.org/r/3527/#comment7719> Just leave Authors on the top line and indent your name. util/tlm/Makefile (line 42) <http://reviews.gem5.org/r/3527/#comment7720> Both of these lines should use pkg-config. I would suggest to do that as a separate patch though, and do it _before_ this patch. util/tlm/Makefile (line 45) <http://reviews.gem5.org/r/3527/#comment7722> could you make a define for the directory rather? util/tlm/Makefile (line 49) <http://reviews.gem5.org/r/3527/#comment7721> c++11 util/tlm/Makefile (line 86) <http://reviews.gem5.org/r/3527/#comment7723> This is a bit dubious, is it not? util/tlm/examples/slave_port/main.cc (line 6) <http://reviews.gem5.org/r/3527/#comment7737> Same as before. util/tlm/main.cc (line 6) <http://reviews.gem5.org/r/3527/#comment7724> Same as before util/tlm/main.cc (line 97) <http://reviews.gem5.org/r/3527/#comment7725> keep the comma on the first line name, other name, yet another name util/tlm/main.cc (line 132) <http://reviews.gem5.org/r/3527/#comment7726> spurious change util/tlm/main.cc (line 163) <http://reviews.gem5.org/r/3527/#comment7727> fits on the line? less than 78 char? util/tlm/main.cc (line 195) <http://reviews.gem5.org/r/3527/#comment7728> again, spurious change util/tlm/main.cc (line 206) <http://reviews.gem5.org/r/3527/#comment7729> i'm not sure why this has changed util/tlm/main.cc (line 219) <http://reviews.gem5.org/r/3527/#comment7730> ame here util/tlm/main.cc (line 228) <http://reviews.gem5.org/r/3527/#comment7731> yet another one util/tlm/payload_event.hh (line 6) <http://reviews.gem5.org/r/3527/#comment7732> Same as before util/tlm/payload_event.hh (line 50) <http://reviews.gem5.org/r/3527/#comment7733> Great. Could you provide a bit more comments though. At the moment it is difficult to grasp. util/tlm/sc_port.hh (line 6) <http://reviews.gem5.org/r/3527/#comment7734> Same as before util/tlm/sc_port.cc (line 89) <http://reviews.gem5.org/r/3527/#comment7735> You may want to call this SCSlavePort or TLMSlavePort or similar to avoid confusion. util/tlm/sim_control.hh (line 6) <http://reviews.gem5.org/r/3527/#comment7736> Same as before - Andreas Hansson On Oct. 26, 2016, 4:11 p.m., Christian Menard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3527/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2016, 4:11 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > The current TLM code only provides a Slave Port that allows the gem5 world to > send requests to the the TLM world. This patch restructures the existing > source code in util/tlm in order to allow for code reuse and a clear file > structure whenn adding a master port implementation. > > > Diffs > ----- > > configs/common/MemConfig.py b3d5f0e9e258 > util/tlm/Makefile b3d5f0e9e258 > util/tlm/README b3d5f0e9e258 > util/tlm/examples/slave_port/main.cc PRE-CREATION > util/tlm/main.cc b3d5f0e9e258 > util/tlm/payload_event.hh PRE-CREATION > util/tlm/run_gem5.sh b3d5f0e9e258 > util/tlm/sc_port.hh b3d5f0e9e258 > util/tlm/sc_port.cc b3d5f0e9e258 > util/tlm/sc_target.hh b3d5f0e9e258 > util/tlm/sc_target.cc b3d5f0e9e258 > util/tlm/sim_control.hh PRE-CREATION > util/tlm/tgen.cfg b3d5f0e9e258 > util/tlm/tlm.py b3d5f0e9e258 > util/tlm/tlm_elastic.py b3d5f0e9e258 > > Diff: http://reviews.gem5.org/r/3527/diff/ > > > Testing > ------- > > The examples provided in util/tlm (now util/tlm/examples/slave_port) still > compile and run error free. > > > Thanks, > > Christian Menard > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
