Hi Alec,

Thanks again for implementing RISC-V in gem5. It's an incredibly important
and timely addition!

As far as I can tell, the patches look good. Hopefully some other will
review them soon as well.

The only thing that's missing that I would really like to have before
pushing the patches is some regression tests for RISC-V. If you could look
at http://gem5.org/Regression_Tests and have a go at adding some
regressions, it would be helpful. It would be *great* if you could make
sure the regressions cover most of what you've implemented (e.g.,
multiply/atomic/etc. instructions, Linux syscalls, etc.). If that isn't
possible, at least having a "hello" regression for a couple of different
CPU models is needed.

Thanks again for your contribution!

Jason
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to