----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3528/#review9002 -----------------------------------------------------------
util/tlm/examples/master_port/main.cc (line 54) <http://reviews.gem5.org/r/3528/#comment7754> This function is also in the target example, could we source out all doublicated functions to a common dir/file? util/tlm/examples/master_port/main.cc (line 74) <http://reviews.gem5.org/r/3528/#comment7757> Similar to the Target (the example TLM memory): put this sc_module in a seperated file... util/tlm/examples/master_port/tlm.py (line 62) <http://reviews.gem5.org/r/3528/#comment7755> remove it if you dont need it util/tlm/sc_master_port.cc (line 99) <http://reviews.gem5.org/r/3528/#comment7756> XXX flag? - Matthias Jung On Okt. 28, 2016, 4:42 nachm., Christian Menard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3528/ > ----------------------------------------------------------- > > (Updated Okt. 28, 2016, 4:42 nachm.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11690:b9fc391b2477 > --------------------------- > misc: add a TLM to Gem5 Master Port > > The current TLM code only provides a Slave Port that allows the gem5 world to > send requests to the the TLM world. This patch adds a Master Port that allows > the TLM world to send requests to the gem5 world. Furthermore, the patch > provides a simple example application based on a TLM traffic generator. > > > Diffs > ----- > > util/tlm/README b3d5f0e9e258 > util/tlm/examples/master_port/SConstruct PRE-CREATION > util/tlm/examples/master_port/main.cc PRE-CREATION > util/tlm/examples/master_port/tlm.py PRE-CREATION > util/tlm/sc_master_port.hh PRE-CREATION > util/tlm/sc_master_port.cc PRE-CREATION > util/tlm/sim_control.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3528/diff/ > > > Testing > ------- > > A simple example application consisting of a TLM traffic generator and a gem5 > memory is part of the patch. > > > Thanks, > > Christian Menard > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
