> On Nov. 1, 2016, 7:09 a.m., Jason Lowe-Power wrote: > > LGTM. Just to double check, if the offset is -3, then offset.hi is 0 and > > offset.low is -3 in two's complement? I.e., if the instruction is 32-bits, > > the offset is NOT sign extended in BRIG?
Yep. That is precisely the scenario which let to discovering this bug, which surpisingly hasn't been stressed before. - Tony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3691/#review9009 ----------------------------------------------------------- On Oct. 31, 2016, 4:13 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3691/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 4:13 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11880:38d5aefff9bd > --------------------------- > hsail: fix unsigned offset bug in address calculation > > it's possible for the offset provided to an HSAIL mem inst to be a negative > value, however the variable we use to hold the offset is an unsigned type. > this can lead to excessively large offset values when the offset is negative, > which will almost certainly cause the access to go out of bounds. > > > Diffs > ----- > > src/arch/hsail/operand.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > > Diff: http://reviews.gem5.org/r/3691/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
