> On Nov. 14, 2016, 7:36 p.m., Michael LeBeane wrote: > > src/sim/syscall_emul.cc, line 236 > > <http://reviews.gem5.org/r/3699/diff/1/?file=63314#file63314line236> > > > > These style changes seem out-of-scope.
Separated into patch: http://reviews.gem5.org/r/3706/. > On Nov. 14, 2016, 7:36 p.m., Michael LeBeane wrote: > > src/sim/syscall_emul.cc, line 222 > > <http://reviews.gem5.org/r/3699/diff/1/?file=63314#file63314line222> > > > > Seems like an unrelated bug fix, should this be in a seperate changeset? Separated into patch: http://reviews.gem5.org/r/3707/. - Brandon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3699/#review9060 ----------------------------------------------------------- On Nov. 7, 2016, 10:09 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3699/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 10:09 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11707:01d31dbe35c4 > --------------------------- > syscall_emul: [PATCH 18/22] refactor and add functionality for dup, dup2, and > pipe > > > Diffs > ----- > > src/arch/arm/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/power/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > > Diff: http://reviews.gem5.org/r/3699/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
