----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3700/#review9105 -----------------------------------------------------------
src/sim/se_signal.hh (line 45) <http://reviews.gem5.org/r/3700/#comment7850> This should not have an underscore, also why not just use signal? - Alexandru Dutu On Nov. 16, 2016, 4:36 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3700/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 4:36 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11728:85a344df47dd > --------------------------- > syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode > > > Diffs > ----- > > src/sim/system.hh c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > src/sim/se_signal.hh PRE-CREATION > src/sim/se_signal.cc PRE-CREATION > src/sim/SConscript c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > > Diff: http://reviews.gem5.org/r/3700/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
