----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3714/#review9109 -----------------------------------------------------------
Ship it! Minor issue, otherwise LGTM. src/arch/hsail/operand.cc (line 230) <http://reviews.gem5.org/r/3714/#comment7852> can you directly initialize reg_kind to BRIG_REGISTER_KIND_DOUBLE? - Tony Gutierrez On Nov. 17, 2016, 12:28 p.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3714/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2016, 12:28 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11707:fd91bcd20fb2 > --------------------------- > hsail: add a wavesize case statement to register operand code > > > Diffs > ----- > > src/arch/hsail/operand.cc c38fcdaa5fe508dbb18cc084e758ad0ce8e2e2f4 > > Diff: http://reviews.gem5.org/r/3714/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
