----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3710/#review9156 -----------------------------------------------------------
Ship it! Ship It! - Fernando Endo On Nov. 18, 2016, 3:21 p.m., Arthur Perais wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3710/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 3:21 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11707:1d085f66c4ca > --------------------------- > cpu: Resolve targets of predicted 'taken' conditional direct branches at > decode (o3) > > The target of taken conditional direct branches does not > need to be resolved in IEW: the target can be computed at > decode, usually using the decoded instruction word and the PC. > > The higher-than-necessary penalty is taken only on conditional > branches that are predicted taken but miss in the BTB. Thus, > this is mostly inconsequential on IPC if the BTB is big/associative > enough (fewer capacity/conflict misses). Nonetheless, what gem5 > simulates is not representative of how conditional branch targets > can be handled. > > > Diffs > ----- > > src/cpu/o3/decode_impl.hh c38fcdaa5fe5 > > Diff: http://reviews.gem5.org/r/3710/diff/ > > > Testing > ------- > > util/regress --modes=se > > build/NULL/tests/opt/quick/se/51.memcheck/null/none/memcheck: FAILED! (Python > says "NameError: name 'TrafficGen' is not defined"). I'm guessing this is OK > as I get the same error without my patch. > > > Thanks, > > Arthur Perais > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
