----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3746/#review9173 -----------------------------------------------------------
Ship it! Ship It! - Mohammad Alian On Nov. 25, 2016, 5:21 p.m., Gabor Dozsa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3746/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2016, 5:21 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11718:dc064d920160 > --------------------------- > dev: Fix race conditions at terminating dist-gem5 simulations > > Two problems may arise when a distributed gem5 simulation terminates: > (i) simulation thread(s) may get stuck in an incomplete synchronisation > event which prohibits processing the simulation exit event; and (ii) a > stale receiver thread may try to access objects that have already been > deleted while exiting gem5. This patch terminates receive threads properly > and aborts the processing of any incomplete synchronisation event. > > Change-Id: I72337aa12c7926cece00309640d478b61e55a429 > Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com> > > > Diffs > ----- > > src/dev/net/dist_iface.hh 27622f94fdcc > src/dev/net/dist_iface.cc 27622f94fdcc > > Diff: http://reviews.gem5.org/r/3746/diff/ > > > Testing > ------- > > > Thanks, > > Gabor Dozsa > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
