Hi Alec, Don’t worry about it. It is the reviewboard being silly.
Andreas On 24/01/2017, 16:34, "gem5-dev on behalf of Alec Roelke" <gem5-dev-boun...@gem5.org on behalf of ar...@virginia.edu> wrote: > > >> On Jan. 24, 2017, 9:43 a.m., Andreas Sandberg wrote: >> > Did you remove all files from the reference output directory? In that >>case, you'll need to add a an empty placeholder file called EMPTY in the >>reference directories. Some VCS systems (git being one of them) don't >>track empty directories, which would interfere with test discovery. > >I did add them; I'm not sure why it didn't put them into the patch. Does >the file need to contain text for it to work? > > >- Alec > > >----------------------------------------------------------- >This is an automatically generated e-mail. To reply, visit: >http://reviews.gem5.org/r/3781/#review9301 >----------------------------------------------------------- > > >On Jan. 24, 2017, 4:33 p.m., Alec Roelke wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.gem5.org/r/3781/ >> ----------------------------------------------------------- >> >> (Updated Jan. 24, 2017, 4:33 p.m.) >> >> >> Review request for Default. >> >> >> Repository: gem5 >> >> >> Description >> ------- >> >> Changeset 11796:1c03f7dcaa8c >> --------------------------- >> riscv: Remove ECALL tests from insttest >> >> The system calls tested in rv64i.cpp in RISC-V's insttest suite have >> different behavior depending on the operating system and file system >>they >> are run on. This patch removes those tests from the regression. >> >> [Change deletion of ECALL test to block comment.] >> [Restore ECALL test but remove test output to test only for completion >> without error.] >> >> >> Diffs >> ----- >> >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/config.ini >>97eebddaae84 >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/config.json >> 97eebddaae84 >> tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/simerr >>97eebddaae84 >> tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/simout >>97eebddaae84 >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/stats.txt >>97eebddaae84 >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/config.ini >> 97eebddaae84 >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/config.jso >>n 97eebddaae84 >> tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/simerr >>97eebddaae84 >> tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/simout >>97eebddaae84 >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/stats.txt >>97eebddaae84 >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/confi >>g.ini 97eebddaae84 >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/confi >>g.json 97eebddaae84 >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/simer >>r 97eebddaae84 >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/simou >>t 97eebddaae84 >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/stats >>.txt 97eebddaae84 >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/config.ini >> 97eebddaae84 >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/config.jso >>n 97eebddaae84 >> tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/simerr >>97eebddaae84 >> tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/simout >>97eebddaae84 >> >>tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/stats.txt >>97eebddaae84 >> >> Diff: http://reviews.gem5.org/r/3781/diff/ >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Alec Roelke >> >> > >_______________________________________________ >gem5-dev mailing list >gem5-dev@gem5.org >http://m5sim.org/mailman/listinfo/gem5-dev IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
