----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3794/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11803:1dba09aeeefd --------------------------- style: Force Python.h to be included before main header Python's header files set various compiler macros (e.g., _XOPEN_SOURCE) unconditionally. This triggers preprocessor warnings that end up being treated as errors. The style guide used to mandate that Python headers are included before any other header. This requirement was changed to always include a source file's main header first, which ended up triggering these errors. This change updates the style checker to always include Python.h before the main header file. Change-Id: Id6a4f7fc64a336a8fd26691a0ca682abeb1d1579 Signed-off-by: Andreas Sandberg <andreas.sandb...@arm.com> Reviewed-by: Nikos Nikoleris <nikos.nikole...@arm.com> Diffs ----- src/python/swig/pyevent.cc be62996c95d1 src/sim/init.cc be62996c95d1 src/sim/py_interact.cc be62996c95d1 util/style/sort_includes.py be62996c95d1 Diff: http://reviews.gem5.org/r/3794/diff/ Testing ------- Thanks, Andreas Sandberg _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
