----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3792/#review9337 -----------------------------------------------------------
Seems reasonable to me. Could you factor out the header change and put it in a separate commit? - Andreas Sandberg On Jan. 26, 2017, 4:47 p.m., Jason Lowe-Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3792/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2017, 4:47 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > misc: Update #!env calls for python to explicit version > > In some newer Linux distributions, env python default to Python 3.0. This > patch explicitly uses "python2" instead of just "python" for all scripts > that use #! > > Reported-by: Sanchayan Maity <maitysancha...@gmail.com> > > > Diffs > ----- > > util/git-pre-commit.py cd7f3a1dbf55 > util/hgstyle.py cd7f3a1dbf55 > util/maint/git-patch-to-hg-patch cd7f3a1dbf55 > util/memtest-soak.py cd7f3a1dbf55 > util/minorview.py cd7f3a1dbf55 > util/o3-pipeview.py cd7f3a1dbf55 > util/oprofile-top.py cd7f3a1dbf55 > util/pbs/job.py cd7f3a1dbf55 > util/pbs/send.py cd7f3a1dbf55 > util/protolib.py cd7f3a1dbf55 > util/qdo cd7f3a1dbf55 > util/decode_inst_dep_trace.py cd7f3a1dbf55 > util/decode_inst_trace.py cd7f3a1dbf55 > util/decode_packet_trace.py cd7f3a1dbf55 > util/dram_lat_mem_rd_plot.py cd7f3a1dbf55 > util/dram_sweep_plot.py cd7f3a1dbf55 > util/encode_inst_dep_trace.py cd7f3a1dbf55 > util/encode_packet_trace.py cd7f3a1dbf55 > util/find_copyrights.py cd7f3a1dbf55 > tests/testing/helpers.py cd7f3a1dbf55 > tests/testing/results.py cd7f3a1dbf55 > tests/testing/tests.py cd7f3a1dbf55 > tests/testing/units.py cd7f3a1dbf55 > tests/tests.py cd7f3a1dbf55 > util/batch/job.py cd7f3a1dbf55 > util/batch/send.py cd7f3a1dbf55 > util/checkpoint-tester.py cd7f3a1dbf55 > util/compile cd7f3a1dbf55 > util/cpt_upgrader.py cd7f3a1dbf55 > ext/mcpat/regression/regression.py cd7f3a1dbf55 > ext/mcpat/regression/verify_output.py cd7f3a1dbf55 > ext/ply/example/classcalc/calc.py cd7f3a1dbf55 > ext/ply/example/newclasscalc/calc.py cd7f3a1dbf55 > src/python/swig/pyevent.hh cd7f3a1dbf55 > src/unittest/genini.py cd7f3a1dbf55 > tests/testing/__init__.py cd7f3a1dbf55 > util/style/style.py cd7f3a1dbf55 > util/style/verifiers.py cd7f3a1dbf55 > util/regress cd7f3a1dbf55 > util/slicc cd7f3a1dbf55 > util/stats/stats.py cd7f3a1dbf55 > util/streamline/m5stats2streamline.py cd7f3a1dbf55 > util/style.py cd7f3a1dbf55 > util/style/__init__.py cd7f3a1dbf55 > util/style/repo.py cd7f3a1dbf55 > util/style/sort_includes.py cd7f3a1dbf55 > > Diff: http://reviews.gem5.org/r/3792/diff/ > > > Testing > ------- > > gem5 compiles on arch with this patch and http://reviews.gem5.org/r/3779/. > > Testing done on arch docker image. See > https://hub.docker.com/r/powerjg/arch-dev/. > Run "docker run -v `pwd`:/gem5/ -it powerjg/arch-dev /bin/bash" to > build/run/test gem5. > > > Thanks, > > Jason Lowe-Power > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
