> On Feb. 3, 2017, 5:31 p.m., Brandon Potter wrote: > > Ship It!
I just posted another patch related to the cd7f3a1dbf55 (brandon@11801) changeset that is needed to get the regression tester working (http://reviews.gem5.org/r/3806/). This patch, 3804, is a preliminary patch that is needed as well. I am a bit frustrated that GCC didn't warn me about the uninitialized variable when this was built with scons. In SConstruct, -Wall is specified in CCFLAGS for GCC (which should warn about uninitialized variables). This wasn't caught and didn't produce a warning for me. Has anyone else encountered this problem or is this unique to my setup? - Brandon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3804/#review9391 ----------------------------------------------------------- On Feb. 3, 2017, 4:29 p.m., Bjoern A. Zeeb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3804/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2017, 4:29 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Seeing build breakage after brandon@11801: > > [ CXX] X86/sim/process.cc -> .o > build/X86/sim/process.cc:137:64: error: field '_pid' is uninitialized when > used here [-Werror,-Wuninitialized] > static_cast<PageTableBase *>(new ArchPageTable(name(), _pid, system)) > : > ^ > build/X86/sim/process.cc:138:64: error: field '_pid' is uninitialized when > used here [-Werror,-Wuninitialized] > static_cast<PageTableBase *>(new FuncPageTable(name(), _pid))), > ^ > 2 errors generated. > > > Diffs > ----- > > src/sim/process.cc 63325e5b0a9d > > Diff: http://reviews.gem5.org/r/3804/diff/ > > > Testing > ------- > > Compiles now on FreeBSD 10 with clang. > > > Thanks, > > Bjoern A. Zeeb > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
