Jason Lowe-Power has uploaded this change for review. (
https://gem5-review.googlesource.com/2760
Change subject: misc: Add MAINTAINERS file
......................................................................
misc: Add MAINTAINERS file
This file defines all of the commit keywords used for gem5 commits and
the maintainter(s) for each of these keywords.
This patch introduces a number of new keywords, and changes to previous
keywords. The new keywords better follow gem5's directory structure and
are more extensible.
Currently, most keywords do not have a maintainer. More maintainers will
be added as more people volunteer to be maintainers.
This patch also updates the CONTRIBUTING.md file to point to this file
instead of listing the keywords separately. When this file is committed
the wiki will also be updated accordingly.
Change-Id: Ib0abfeb39a3ca01b74b340e24dc9a2cd95ff813f
Signed-off-by: Jason Lowe-Power <[email protected]>
---
M CONTRIBUTING.md
A MAINTAINERS
2 files changed, 87 insertions(+), 29 deletions(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index a9781a3..e1b3c6d 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -113,10 +113,10 @@
A canonical commit message consists of three parts:
* A short summary line describing the change. This line starts with one or
- more keywords separated by commas followed by a colon and a description
of
- the change. This line should be no more than 65 characters long since
- version control systems usually add a prefix that causes line-wrapping
for
- longer lines.
+ more keywords (found in the MAINTAINERS file) separated by commas
followed
+ by a colon and a description of the change. This line should be no more
than
+ 65 characters long since version control systems usually add a prefix
that
+ causes line-wrapping for longer lines.
* (Optional, but highly recommended) A detailed description. This
describes
what you have done and why. If the change isn't obvious, you might want
to
motivate why it is needed. Lines need to be wrapped to 75 characters or
@@ -125,31 +125,6 @@
tags to acknowledge reviewers for their work. Gerrit will automatically
add
most tags.
-The keyword should be one or more of the following separated by commas:
- * Architecture name in lower case (e.g., arm or x86): Anything that is
- target-architecture specific.
- * base
- * ext
- * stats
- * sim
- * syscall_emul
- * config:
- * mem: Classic memory system. Ruby uses its own keyword.
- * ruby: Ruby memory models.
- * cpu: CPU-model specific (except for kvm)
- * kvm: KVM-specific. Changes to host architecture specific components
should
- include an architecture keyword (e.g., arm or x86) as well.
- * gpu-compute
- * energy
- * dev
- * arch: General architecture support (src/arch/)
- * scons: Build-system related. Trivial changes as a side effect of doing
- something unrelated (e.g., adding a source file to a SConscript) don't
- require this.
- * tests
- * style: Changes to the style checkers of style fixes.
- * misc
-
Tags are an optional mechanism to store additional metadata about a patch
and
acknowledge people who reported a bug or reviewed that patch. Tags are
generally appended to the end of the commit message in the order they
happen.
diff --git a/MAINTAINERS b/MAINTAINERS
new file mode 100644
index 0000000..120121b
--- /dev/null
+++ b/MAINTAINERS
@@ -0,0 +1,83 @@
+See CONTRIBUTING.md for details of gem5's contribution process.
+
+This file contains the keywords used in commit messages. Each keyword has
one
+or more maintainers. At least one (not all) of these maintainers must
review
+the patch before it can be pushed. These people will automatically be
emailed
+when you upload the patch to Gerrit (https://gem5-review.googlesource.com).
+These keywords mostly follow the directory structure.
+
+Individuals on the project management committee are maintainers for all of
the
+gem5 components (i.e., they can review any patch as the maintainer). These
+individuals are required to review any patches to components without
explicit
+maintainers.
+
+PMC Members (general maintainers):
+ Ali Saidi <[email protected]>
+ Andreas Hansson <[email protected]>
+ Andreas Sandberg <[email protected]>
+ Anthony Gutierrez <[email protected]>
+ Brad Beckmann <[email protected]>
+ Jason Lowe-Power <[email protected]>
+ Nathan Binkert <[email protected]>
+ Steve Reinhardt <[email protected]>
+
+arch: General architecture-specific components
+arch-alpha:
+arch-arm:
+ Andreas Sandberg <[email protected]>
+arch-hsail:
+ Tony Gutierrez <[email protected]>
+arch-mips:
+arch-power:
+arch-riscv:
+ Alec Roelke <[email protected]>
+arch-sparc:
+arch-x86:
+
+base:
+
+configs:
+ Jason Lowe-Power <[email protected]>
+
+cpu: General changes to all CPU models (e.g., BaseCPU)
+cpu-kvm:
+ Andreas Sandberg <[email protected]>
+cpu-minor:
+cpu-o3:
+cpu-simple:
+
+dev:
+dev-virtio:
+ Andreas Sandberg <[email protected]>
+
+ext: Components external to gem5
+
+gpu-compute:
+ Tony Gutierrez <[email protected]>
+
+mem: General memory system (e.g., XBar, Packet)
+mem-cache: Classic caches and coherence
+mem-garnet: Garnet subcomponent of Ruby
+ Tushar Krishna <[email protected]>
+mem-ruby: Ruby structures and protocols
+ Brad Beckmann <[email protected]>
+ Jason Lowe-Power <[email protected]>
+
+misc: Anything outside of the other categories
+
+python: Python SimObject wrapping and infrastructure
+
+regress: testing changes (not stats updates for tests. See stats:)
+
+scons: Build system
+
+sim: General simulation components
+ Jason Lowe-Power <[email protected]>
+sim-se: Syscall emulation
+ Brandon Potter <[email protected]>
+sim-power: Power modeling
+ Andreas Sandberg <[email protected]>
+
+stats: Updates to statistics for regressions
+
+util:
--
To view, visit https://gem5-review.googlesource.com/2760
To unsubscribe, visit https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0abfeb39a3ca01b74b340e24dc9a2cd95ff813f
Gerrit-Change-Number: 2760
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Lowe-Power <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
