Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/2905
to review the following change.
Change subject: config: Warn not fail for ARM systems configured with ruby
......................................................................
config: Warn not fail for ARM systems configured with ruby
Ruby for ARM systems is not fully supported but certain configurations
are expected to work. This change removes the more general fail
statement and warns or fails depending on the particular
configuration.
Change-Id: Ic24799aff966ba15858b93482e0f24a8672d9483
Reviewed-by: Andreas Sandberg <[email protected]>
---
M configs/common/FSConfig.py
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/configs/common/FSConfig.py b/configs/common/FSConfig.py
index 3a169a4..d15800e 100644
--- a/configs/common/FSConfig.py
+++ b/configs/common/FSConfig.py
@@ -1,4 +1,4 @@
-# Copyright (c) 2010-2012, 2015-2016 ARM Limited
+# Copyright (c) 2010-2012, 2015-2017 ARM Limited
# All rights reserved.
#
# The license below extends only to copyright in the software and shall
@@ -394,9 +394,12 @@
self.system_port = self.membus.slave
if ruby:
- fatal("You're trying to use Ruby on ARM, which is not working " \
- "properly yet. If you want to test it anyway, you " \
- "need to remove this fatal error from FSConfig.py.")
+ if buildEnv['PROTOCOL'] == 'MI_example' and num_cpus > 1:
+ fatal("The MI_example protocol cannot implement Load/Store "
+ "Exclusive operations. Multicore ARM systems configured "
+ "with the MI_example protocol will not work properly.")
+ warn("You are trying to use Ruby on ARM, which is not working "
+ "properly yet.")
return self
--
To view, visit https://gem5-review.googlesource.com/2905
To unsubscribe, visit https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic24799aff966ba15858b93482e0f24a8672d9483
Gerrit-Change-Number: 2905
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
