Andreas Sandberg has submitted this change and it was merged. (
https://gem5-review.googlesource.com/3880 )
Change subject: mem-cache: Add missing overrides to BaseCache
......................................................................
mem-cache: Add missing overrides to BaseCache
Change-Id: I6a3a57e3067c247bd6ce6f01ac9459883f4aae2c
Signed-off-by: Andreas Sandberg <andreas.sandb...@arm.com>
Reviewed-by: Nikos Nikoleris <nikos.nikole...@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/3880
Reviewed-by: Jason Lowe-Power <ja...@lowepower.com>
Maintainer: Jason Lowe-Power <ja...@lowepower.com>
Maintainer: Nikos Nikoleris <nikos.nikole...@arm.com>
---
M src/mem/cache/base.hh
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Nikos Nikoleris: Looks good to me, approved; Looks good to me, approved
diff --git a/src/mem/cache/base.hh b/src/mem/cache/base.hh
index 2f4b934..431c2f8 100644
--- a/src/mem/cache/base.hh
+++ b/src/mem/cache/base.hh
@@ -228,7 +228,7 @@
/**
* Write back dirty blocks in the cache using functional accesses.
*/
- virtual void memWriteback() = 0;
+ virtual void memWriteback() override = 0;
/**
* Invalidates all blocks in the cache.
*
@@ -236,7 +236,7 @@
* memory. Make sure to call functionalWriteback() first if you
* want the to write them to memory.
*/
- virtual void memInvalidate() = 0;
+ virtual void memInvalidate() override = 0;
/**
* Determine if there are any dirty blocks in the cache.
*
@@ -460,18 +460,18 @@
/**
* Register stats for this object.
*/
- virtual void regStats();
+ virtual void regStats() override;
public:
BaseCache(const BaseCacheParams *p, unsigned blk_size);
~BaseCache() {}
- virtual void init();
+ virtual void init() override;
virtual BaseMasterPort &getMasterPort(const std::string &if_name,
- PortID idx = InvalidPortID);
+ PortID idx = InvalidPortID)
override;
virtual BaseSlavePort &getSlavePort(const std::string &if_name,
- PortID idx = InvalidPortID);
+ PortID idx = InvalidPortID)
override;
/**
* Query block size of a cache.
--
To view, visit https://gem5-review.googlesource.com/3880
To unsubscribe, visit https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a3a57e3067c247bd6ce6f01ac9459883f4aae2c
Gerrit-Change-Number: 3880
Gerrit-PatchSet: 2
Gerrit-Owner: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Nikos Nikoleris <nikos.nikole...@arm.com>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev