[gem5-dev] Change in public/gem5[master]: dev: Fix OnIdle test in DmaReadFifo

[Andreas Sandberg (Gerrit)]

Andreas Sandberg has uploaded this change for review. (  
https://gem5-review.googlesource.com/3966

Change subject: dev: Fix OnIdle test in DmaReadFifo
......................................................................

dev: Fix OnIdle test in DmaReadFifo

OnIdle() is never called since DMA active check is completely
opposite to what it should be. old active status should be 'true'
and new active status should be false for OnIdle to be called

Signed-off-by:Rohit Kurup <rohit.ku...@arm.com>
Reported-by:Rohit Kurup <rohit.ku...@arm.com>

Change-Id: I94eca50edbe96113190837c7f6e50a0d061158a6
Signed-off-by: Andreas Sandberg <andreas.sandb...@arm.com>
---
M src/dev/dma_device.cc
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/dev/dma_device.cc b/src/dev/dma_device.cc
index a78819a..f6f751c 100644
--- a/src/dev/dma_device.cc
+++ b/src/dev/dma_device.cc
@@ -438,7 +438,7 @@
     handlePending();
     resumeFill();

-    if (!old_active && isActive())
+    if (old_active && !isActive())
         onIdle();
 }


--
To view, visit https://gem5-review.googlesource.com/3966
To unsubscribe, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94eca50edbe96113190837c7f6e50a0d061158a6
Gerrit-Change-Number: 3966
Gerrit-PatchSet: 1
Gerrit-Owner: Andreas Sandberg <andreas.sandb...@arm.com>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev