Hello Gabe Black, Andreas Sandberg,

I'd like you to reexamine a change. Please visit

    https://gem5-review.googlesource.com/5802

to look at the new patch set (#12).

Change subject: misc: Updates for gcc7.2 for x86
......................................................................

misc: Updates for gcc7.2 for x86

GCC 7.2 is much stricter than previous GCC versions. The following changes
are needed:

* There is now a warning if there is an implicit fallthrough between two
  case statments. C++17 adds the [[fallthrough]]; declaration. However,
  to support non C++17 standards (i.e., C++11), we use M5_FALLTHROUGH.
  M5_FALLTHROUGH checks for [[fallthrough]] compliant C++17 compiler and
  if that doesn't exist, it defaults to nothing (no older compilers
  generate warnings).
* The above resulted in a couple of bugs that were found. This is noted
  in the review request on gerrit.
* throw() for dynamic exception specification is deprecated
* There were a couple of new uninitialized variable warnings
* Can no longer perform bitwise operations on a bool.
* Must now include <functional> for std::function
* Compiler bug for void* lambda. Changed to auto as work around. See
  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82878

Change-Id: I5d4c782a4e133fa4cdb119e35d9aff68c6e2958e
Signed-off-by: Jason Lowe-Power <ja...@lowepower.com>
---
M ext/dnet/ip.h
M ext/drampower/src/Utils.h
M src/arch/arm/isa.cc
M src/arch/arm/table_walker.cc
M src/arch/x86/isa.cc
M src/arch/x86/isa/microops/regop.isa
M src/base/compiler.hh
M src/base/cprintf.cc
M src/base/imgwriter.cc
M src/cpu/kvm/base.cc
M src/cpu/kvm/x86_cpu.cc
M src/cpu/minor/dyn_inst.cc
M src/dev/arm/generic_timer.cc
M src/dev/net/i8254xGBe.cc
M src/dev/pci/copy_engine.cc
M src/dev/storage/ide_disk.cc
M src/dev/x86/i8042.cc
M src/kern/linux/printk.cc
M src/mem/slicc/symbols/Type.py
M src/sim/eventq.hh
M src/sim/fd_array.cc
21 files changed, 54 insertions(+), 56 deletions(-)


--
To view, visit https://gem5-review.googlesource.com/5802
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5d4c782a4e133fa4cdb119e35d9aff68c6e2958e
Gerrit-Change-Number: 5802
Gerrit-PatchSet: 12
Gerrit-Owner: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-CC: Brandon Potter <brandon.pot...@amd.com>
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to