Hello Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/7824
to review the following change.
Change subject: arch-arm: Fix cache line size for cache maintenace inst
......................................................................
arch-arm: Fix cache line size for cache maintenace inst
Cache maintenance operations operate on whole cache blocks. This
changeset uses the system cache line size as the size of the cache
maintenance requests and masks the lower bits of the effective
address.
Change-Id: I6e7aefff51670c8cac39e4e73db21a0c5a0b7aef
Reviewed-by: Andreas Sandberg <[email protected]>
---
M src/arch/arm/isa/templates/misc.isa
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/arch/arm/isa/templates/misc.isa
b/src/arch/arm/isa/templates/misc.isa
index 639ff3a..6d63b8e 100644
--- a/src/arch/arm/isa/templates/misc.isa
+++ b/src/arch/arm/isa/templates/misc.isa
@@ -1,6 +1,6 @@
// -*- mode:c++ -*-
-// Copyright (c) 2010-2013,2017 ARM Limited
+// Copyright (c) 2010-2013,2017-2018 ARM Limited
// All rights reserved
//
// The license below extends only to copyright in the software and shall
@@ -646,9 +646,9 @@
}
if (fault == NoFault) {
- Addr size = 64;
- EA &= ~(size - 1);
- fault = xc->writeMem(NULL, size, EA, memAccessFlags, NULL);
+ Addr op_size =
xc->tcBase()->getSystemPtr()->cacheLineSize();
+ EA &= ~(op_size - 1);
+ fault = xc->writeMem(NULL, op_size, EA, memAccessFlags,
NULL);
}
} else {
xc->setPredicate(false);
@@ -675,9 +675,9 @@
}
if (fault == NoFault) {
- Addr size = 64;
- EA &= ~(size - 1);
- fault = xc->writeMem(NULL, size, EA, memAccessFlags, NULL);
+ Addr op_size =
xc->tcBase()->getSystemPtr()->cacheLineSize();
+ EA &= ~(op_size - 1);
+ fault = xc->writeMem(NULL, op_size, EA, memAccessFlags,
NULL);
}
} else {
xc->setPredicate(false);
--
To view, visit https://gem5-review.googlesource.com/7824
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e7aefff51670c8cac39e4e73db21a0c5a0b7aef
Gerrit-Change-Number: 7824
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
