Nayan Deshmukh has submitted this change and it was merged. ( https://gem5-review.googlesource.com/7801 )

Change subject: config: remove dead code in fs.py
......................................................................

config: remove dead code in fs.py

We have not added the --generate-dtb option for non-ARM systems and
hence this case becomes dead code. It also leads to error on non-ARM
systems as is tries to access a non existent field.

Change-Id: Ia926bd0c61efa275bc5e3864b8a9c3ffb7aa3cb5
Signed-off-by: Nayan Deshmukh <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/7801
Reviewed-by: Curtis Dunham <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M configs/example/fs.py
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
  Curtis Dunham: Looks good to me, approved



diff --git a/configs/example/fs.py b/configs/example/fs.py
index 031457c..f7115eb 100644
--- a/configs/example/fs.py
+++ b/configs/example/fs.py
@@ -392,8 +392,5 @@
             sys = getattr(root, sysname)
sys.dtb_filename = create_dtb_for_system(sys, '%s.dtb' % sysname)

-elif buildEnv['TARGET_ISA'] != "arm" and options.generate_dtb:
-    fatal("Can only generate dtb files for ARM systems.")
-
 Simulation.setWorkCountOptions(test_sys, options)
 Simulation.run(options, root, test_sys, FutureClass)

--
To view, visit https://gem5-review.googlesource.com/7801
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia926bd0c61efa275bc5e3864b8a9c3ffb7aa3cb5
Gerrit-Change-Number: 7801
Gerrit-PatchSet: 2
Gerrit-Owner: Nayan Deshmukh <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Curtis Dunham <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nayan Deshmukh <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to