Hello Curtis Dunham,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/8284
to review the following change.
Change subject: mem-cache: Populate the secure bit when the temp block is
filled
......................................................................
mem-cache: Populate the secure bit when the temp block is filled
The secure bit should be set when we fill a block with data from a
secure location, as indicated by the packet that triggers the fill.
This patch fixes a bug in which the cache wouldn't populate the secure
bit when filling the temp block.
Change-Id: I95c706146449804ff42b205b25dd79750f3e882a
Reviewed-by: Curtis Dunham <[email protected]>
---
M src/mem/cache/cache.cc
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mem/cache/cache.cc b/src/mem/cache/cache.cc
index 622f0f7..64438c1 100644
--- a/src/mem/cache/cache.cc
+++ b/src/mem/cache/cache.cc
@@ -1902,7 +1902,9 @@
blk = tempBlock;
tempBlock->set = tags->extractSet(addr);
tempBlock->tag = tags->extractTag(addr);
- // @todo: set security state as well...
+ if (is_secure) {
+ tempBlock->status |= BlkSecure;
+ }
DPRINTF(Cache, "using temp block for %#llx (%s)\n", addr,
is_secure ? "s" : "ns");
} else {
--
To view, visit https://gem5-review.googlesource.com/8284
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95c706146449804ff42b205b25dd79750f3e882a
Gerrit-Change-Number: 8284
Gerrit-PatchSet: 1
Gerrit-Owner: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: Curtis Dunham <[email protected]>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
